Patch Set 5:

(6 comments)

Will share the patch with Mike soon

View Change

6 comments:

• File payloads/libpayload/Kconfig:

  • Patch Set #5, Line 267: bool "SC7180 SOC compatible serial port driver"

    Since it seems that this driver works for multiple Qualcomm SoCs, should we maybe give it a more gen […]

    Done

  • Patch Set #5, Line 271: config CONSOLE_UART

    Not necessary since we have the base address in the coreboot table instead.

    Done

• File payloads/libpayload/drivers/serial/qcom_qup_se.c:

  • Patch Set #5, Line 33: struct qup_regs *qup[12] = {

    This shouldn't be necessary since we can get the QUP base address from the coreboot table.

    Done

• File payloads/libpayload/drivers/serial/sc7180.c:

  • Patch Set #5, Line 101: struct qup_regs *regs = qup[idx];

    You should do […]

    Done

  • Patch Set #5, Line 115: {

    You should check […]

    Done

• File payloads/libpayload/include/qcom_qup_se.h:

  • Patch Set #5:

    Since we'll only have the UART driver and no other QUP-related stuff in libpayload, I think it would […]

    Done

To view, visit change 35960. To unsubscribe, or for help writing mail filters, visit settings.