Attention is currently required from: Felix Singer, Martin L Roth, David Hendricks, Paul Menzel, Angel Pons, Elyes Haouas.

View Change

1 comment:

• Patchset:

  • Patch Set #20:

    FYI, one thing clang-format seems to handle poorly is consecutive macros that have indented bit definitions. For example, after running `clang-format-15 -i -style=file` with this patch applied, I see things like:
    -#define MSR_FEATURE_CONFIG 0x13c
    -#define FEATURE_CONFIG_LOCK BIT(0)
    +#define MSR_FEATURE_CONFIG 0x13c
    +#define FEATURE_CONFIG_LOCK BIT(0)

    In this case the indentation before FEATURE_CONFIG_LOCK makes it more obvious that it's a field within MSR_FEATURE_CONFIG. I'm not sure if there's a way to make clang-format follow that convention, but thought it's worth mentioning.

    Maybe not aligning macros is a good idea here?

To view, visit change 64779. To unsubscribe, or for help writing mail filters, visit settings.