I like the idea, though I have just done a quick read.
Patch set 1:Code-Review +1
View Change
1 comment:
Commit Message:
Patch Set #1, Line 7: warning
Why a warning?
If there are not many false positives, I would suggest making this an error. Nobody should try to get past getting a build/boot error.
To view, visit change 33641. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2a1ccb62c7678f264015c87b9004be6a106f804a
Gerrit-Change-Number: 33641
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Fri, 21 Jun 2019 01:19:21 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment