View Change
2 comments:
Commit Message:
Patch Set #1, Line 9:
H.
PUFF
nit: either drop the line-break or add a full newline
Done
Patch Set #1, Line 10: PUFF-based variants do not have an attached display
agreed; when they are different devices, they should be split. […]
Chromeboxes and potentially Chromebases (so, all-in-one with a non-eDP attached display). Hard to tell when not all variants released or mapped to future products
To view, visit change 49058. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5ce4c6e1c78299e89760a1356da452d56ba0aee6
Gerrit-Change-Number: 49058
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier <matt.devillier@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-Reviewer: Nico Huber <nico.h@gmx.de>
Gerrit-Reviewer: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Comment-Date: Sun, 03 Jan 2021 17:52:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons <th3fanbus@gmail.com>
Comment-In-Reply-To: Michael Niewöhner <foss@mniewoehner.de>
Gerrit-MessageType: comment