Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49058 )
Change subject: mb/google/hatch (baseboard): add ACPI backlight support ......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@9 PS1, Line 9: H. : PUFF
nit: either drop the line-break or add a full newline
Done
https://review.coreboot.org/c/coreboot/+/49058/1//COMMIT_MSG@10 PS1, Line 10: PUFF-based variants do not have an attached display
agreed; when they are different devices, they should be split. […]
Chromeboxes and potentially Chromebases (so, all-in-one with a non-eDP attached display). Hard to tell when not all variants released or mapped to future products