Attention is currently required from: Tarun Tuli, Reka Norman.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/71707 )
Change subject: mb/google/nissa: Enable eNEM
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/brya/Kconfig:
https://review.coreboot.org/c/coreboot/+/71707/comment/e35669d3_61a47a7a
PS1, Line 302: if BOARD_GOOGLE_PRIMUS4ES || BOARD_GOOGLE_GIMBLE4ES || BOARD_GOOGLE_REDRIX4ES || BOARD_GOOGLE_TAEKO4ES || BOARD_GOOGLE_ANAHERA4ES || BOARD_GOOGLE_TANIKS || BOARD_GOOGLE_SKOLAS || BOARD_GOOGLE_SKOLAS4ES || BOARD_GOOGLE_ZYDRON
Could we maybe make a different config option "DEFALT_ADL_NEM" that is selected by these boards instead of just having a giant list of boards here?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/71707
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iad48976e405403ab61c71d8f72e0616ea8b85ebd
Gerrit-Change-Number: 71707
Gerrit-PatchSet: 1
Gerrit-Owner: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Kangheui Won
khwon@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Reka Norman
rekanorman@google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Comment-Date: Sun, 08 Jan 2023 01:16:55 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
