Attention is currently required from: Patrick Georgi, Jason Nien, Matt DeVillier, Martin Roth, Felix Held.
Hello build bot (Jenkins), Raul Rangel, Jason Nien, Matt DeVillier, Matt DeVillier, Martin Roth,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/72182
to look at the new patch set (#2).
Change subject: soc/amd/stoneyridge: remove LIDS field from global NVS ......................................................................
soc/amd/stoneyridge: remove LIDS field from global NVS
Since the LIDS field is only used in the ACPI code and not in the C code of any mainboard using the Stoneyridge SoC, remove it form the global NVS and add an ACPI object for this in the DSDT of the mainboards that use it in their ACPI code. Eventually the LIDS object should probably be moved to the EC's ACPI code, but that's out of scope for this patch.
TEST=google/liara doesn't show ACPI errors in Linux' dmesg
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I778c4189607035b4765c6cb8b2e74030dcf9069f --- M src/mainboard/google/kahlee/dsdt.asl M src/soc/amd/stoneyridge/acpi/globalnvs.asl M src/soc/amd/stoneyridge/include/soc/nvs.h 3 files changed, 33 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/82/72182/2