Attention is currently required from: Nico Huber, Patrick Rudolph. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47107 )
Change subject: option.h: Introduce {get,set}_int_option() functions ......................................................................
Patch Set 6:
(2 comments)
File src/include/option.h:
https://review.coreboot.org/c/coreboot/+/47107/comment/c15565ac_18a4f183 PS6, Line 6: #include <types.h> Eh, enum cb_err
https://review.coreboot.org/c/coreboot/+/47107/comment/cbe32195_6b236ff1 PS6, Line 29: set_option
should this print an error on failure to set the CMOS option? Or use an assertion?
No, why? If `cmos_set_option` runs into some error, it can print a more accurate error message. Plus, if CMOS is not enabled, errors would be expected.
About using an assertion: assertions are supposed to be fatal. While errors in the option code may indicate something more serious is going on, it's not enough of a reason to halt.