Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49055 )
Change subject: soc/intel/tigerlake: Add Kconfig options for each platform
......................................................................
Patch Set 3:
Thanks, Nate, for the elaborate answer.
I think we should add a choice with a prompt for the FSP version
to `soc/intel/tigerlake/Kconfig` that always defaults to "Client".
In a more advanced solution, both options of the choice could
depend on `SOC_INTEL_TIGERLAKE_(CLIENT|IOT)` each, so we
don't show invalid options if we know exactly what a board ships
with (e.g. for something called UP4, we could hide the IoT option).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/49055
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I575f28c7eaa82ed5d52ba7c9328a52e76d71dc5b
Gerrit-Change-Number: 49055
Gerrit-PatchSet: 3
Gerrit-Owner: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nathaniel L Desimone
nathaniel.l.desimone@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 05 Jan 2021 01:04:14 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment