Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35985 )
Change subject: intel/skylake: Implement PCIe RP devicetree update based on DID ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip... File src/soc/intel/skylake/chip.c:
https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip... PS14, Line 49: offset = 8, .count = 4
I didn't look into the new implementation, yet, but if we can't drop this? non-existing ports should […]
Well, I guess the count could be dropped if we assume to always have 8 ports per group... I don't know if that is spec or Intel specific. The same applies to the offset; simply count up by 8 in pcie_rp_update_devicetree() would make this unneeded.
https://review.coreboot.org/c/coreboot/+/35985/14/src/soc/intel/skylake/chip... PS14, Line 83: if (CONFIG(SKYLAKE_SOC_PCH_H)) : pcie_rp_update_devicetree(pch_h_rp_groups); : else : pcie_rp_update_devicetree(pch_lp_rp_groups); :
same as above; maybe we can throw all possible groups in one list... […]
Not sure how that could be realized... I don't think it's really worth it :)