Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41440 )
Change subject: sconfig: Add support for firmware configuration ......................................................................
Patch Set 14:
(2 comments)
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c File util/sconfig/main.c:
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c@557 PS14, Line 557: field = find_fw_config_field(probe->field); : if (!field) { : printf("ERROR: fw_config_probe field %s not found\n", probe->field); : exit(1); : } : option = find_fw_config_option(field, probe->option); : if (!option) { : printf("ERROR: fw_config_probe field %s option %s not found\n", : probe->field, probe->option); : exit(1); : }
Should these be done in add_fw_config_probe() instead so that we don't exit() with file opened?
I think I would need to do it in another pass after everything has been processed so that override options get checked too.
I can at least close autohead/autogen before exit.
https://review.coreboot.org/c/coreboot/+/41440/14/util/sconfig/main.c@1495 PS14, Line 1495:
I think we will need something here(like update_fw_config_probe) to copy the probe properties of a d […]
I did this intentionally because this allows an override to remove all the probe entries and/or define it's own. Otherwise there is no way for an override device to remove a probe from the list.
I can change it if you think that this isn't something we need to accommodate. I should update the doc either way so it is clear how overrides work for probing...