Patch Set 25:

Patch Set 25:

Patch Set 25: Code-Review-1

This will make it significantly harder to edit and read the SPD files in the tree.

The hex-to-bin handling has been a mess. we might be better off building an SPD editor (in golang? ;-) ) and stop pretending that this stuff is source.

How about bincfg? we already have DDR3 and DDR4 spec files.

I brought that up early in the discussion of this effort. The main counterargument was that just throwing binary files around is dead simple (and won't fail with vendors adding some custom flags somewhere or whatever).

We could document a workflow with bincfg to edit the binaries, though.

I guess this boils down to: should we get the binary representation in (and do whatever is necessary to make editing a painless experience, better than it is now) or do we need to investigate a text format we want to use (bincfg or anything else) as part of the build process?

View Change

To view, visit change 44775. To unsubscribe, or for help writing mail filters, visit settings.