Nick Vaccaro submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Furquan Shaikh: Looks good to me, approved
mb/google/volteer/variants/eldrid: Include SPD for H4AAG165WB-BCWE

Add SPD support to eldrid for DDR4 memory part H4AAG165WB-BCWE.

Eldrid should use DRAM_ID strap ID 4 (0100) on SKUs populated
with H4AAG165WB-BCWE DDR4 memory parts.

BUG=b:181732562
TEST="FW_NAME=eldrid emerge-volteer coreboot" and verify it builds
successfully.

Change-Id: I38cfe3eb26b00563ce17df3a3ac2a0a846f2ae00
Signed-off-by: Nick Vaccaro <nvaccaro@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/51667
Reviewed-by: Furquan Shaikh <furquan@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
M src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
M src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
3 files changed, 3 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
index b966612..b2ab8ca 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/Makefile.inc
@@ -6,4 +6,4 @@
SPD_SOURCES += ddr4-spd-1.hex # ID = 1(0b0001) Parts = MT40A512M16TB-062E:J
SPD_SOURCES += ddr4-spd-2.hex # ID = 2(0b0010) Parts = H5ANAG6NCMR-XNC
SPD_SOURCES += ddr4-spd-7.hex # ID = 3(0b0011) Parts = K4AAG165WA-BCWE, MT40A1G16KD-062E:E
-SPD_SOURCES += ddr4-spd-9.hex # ID = 4(0b0100) Parts = H5ANAG6NCJR-XNC
+SPD_SOURCES += ddr4-spd-9.hex # ID = 4(0b0100) Parts = H5ANAG6NCJR-XNC, K4AAG165WB-BCWE
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
index 3e298dc..3b5315a 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/dram_id.generated.txt
@@ -6,3 +6,4 @@
K4AAG165WA-BCWE 3 (0011)
MT40A1G16KD-062E:E 3 (0011)
H5ANAG6NCJR-XNC 4 (0100)
+K4AAG165WB-BCWE 4 (0100)
diff --git a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
index dbe7ecb..7a8cdf8 100644
--- a/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
+++ b/src/mainboard/google/volteer/variants/eldrid/memory/mem_list_variant.txt
@@ -5,3 +5,4 @@
K4AAG165WA-BCWE
MT40A1G16KD-062E:E
H5ANAG6NCJR-XNC
+K4AAG165WB-BCWE

To view, visit change 51667. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I38cfe3eb26b00563ce17df3a3ac2a0a846f2ae00
Gerrit-Change-Number: 51667
Gerrit-PatchSet: 4
Gerrit-Owner: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Martin Roth <martinroth@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Patrick Georgi <pgeorgi@google.com>
Gerrit-Reviewer: Zhuohao Lee <zhuohao@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-MessageType: merged