Attention is currently required from: Jason Glenesk, Furquan Shaikh, Marshall Dawson, Felix Held.
View Change
1 comment:
Commit Message:
Patch Set #1, Line 10: change consolidates the clear logic into one spot.
I think it would be good to mention here that this changes the behavior for Picasso since the decode […]
Right, we should guard espi_setup in bootblock.c with !VBOOT_STARTS_BEFORE_BOOTBLOCK. There is no reason to redo it if psp_verstage did it.
To view, visit change 52064. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic57689e50febd29796d8ac8d99c81e41fee5b41c
Gerrit-Change-Number: 52064
Gerrit-PatchSet: 1
Gerrit-Owner: Raul Rangel <rrangel@chromium.org>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Reviewer: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-Attention: Jason Glenesk <jason.glenesk@gmail.com>
Gerrit-Attention: Furquan Shaikh <furquan@google.com>
Gerrit-Attention: Marshall Dawson <marshalldawson3rd@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Fri, 02 Apr 2021 21:16:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh <furquan@google.com>
Gerrit-MessageType: comment