Attention is currently required from: Lance Zhao, Wonkyu Kim, Angel Pons, Felix Held.
View Change
1 comment:
File src/acpi/acpi.c:
Patch Set #3, Line 186: int acpi_create_madt_ioapic_from_hw(acpi_madt_ioapic_t *ioapic, u32 addr)
hmm, i'd at least add a comment that in systems with more than one ioapic the function needs to be c […]
Right, this needs to fixed, a comment is not enough.
I believe I found a requirement that the I/O APIC emulating / providing some i8259 compatibility needs to map GSI 0-15 to match legacy IRQs 0-15. Platforms might (well aopen/dxplplusu does) have hardcoded _PRT GSI entries.
To view, visit change 55310. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia173582eaad305000f958c5d207e9efaa06d8750
Gerrit-Change-Number: 55310
Gerrit-PatchSet: 3
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Felix Held <felix-coreboot@felixheld.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Lance Zhao
Gerrit-Attention: Wonkyu Kim <wonkyu.kim@intel.com>
Gerrit-Attention: Angel Pons <th3fanbus@gmail.com>
Gerrit-Attention: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Comment-Date: Thu, 17 Jun 2021 03:16:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held <felix-coreboot@felixheld.de>
Gerrit-MessageType: comment