Attention is currently required from: Furquan Shaikh, Martin Roth, Duncan Laurie, Angel Pons, Karthik Ramasubramanian.
Mathew King has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/50005 )
Change subject: mb/google/mi: Rename guybrush mainboard to monkey_island
......................................................................
Patch Set 4:
(4 comments)
Patchset:
PS2:
It still feels to me that baseboard belongs under the mainboard and not under variants and it has […]
Done
File src/mainboard/google/guybrush/Kconfig:
https://review.coreboot.org/c/coreboot/+/50005/comment/58583518_6fb9ead8
PS2, Line 33: variants
Tried to explain above on the patchset level comment.
Ack
File src/mainboard/google/guybrush/baseboard/devicetree.cb:
PS2:
I know zork did it that way but I felt that is layout would be easier to maintain.
Done
File src/mainboard/google/guybrush/baseboard/include/baseboard/variants.h:
PS2:
This file was named correctly. There is no need to change the path.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/50005
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0cd1cac2a4d697373d508f2260fdca4b88fdf10d
Gerrit-Change-Number: 50005
Gerrit-PatchSet: 4
Gerrit-Owner: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Martin Roth
martinroth@google.com
Gerrit-Attention: Duncan Laurie
dlaurie@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 28 Jan 2021 20:35:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Comment-In-Reply-To: Mathew King
mathewk@chromium.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment