14 comments:
File src/mainboard/google/kukui/Makefile.inc:
insert a space character
Done
File src/mainboard/google/kukui/mainboard.c:
#include <console/console.h>
#include <cbfs.h>
#include <device/device.h>
#include <soc/gpio.h>
#include <soc/mmu_operations.h>
#include <soc/usb.h>
#include <soc/sspm.h>
sort include lines
Done
Patch Set #1, Line 49: CBFS_TYPE_RAW);
code indent should use tabs where possible
Done
Patch Set #1, Line 49: CBFS_TYPE_RAW);
please, no spaces at the start of a line
Done
Patch Set #1, Line 55: buf[0], fw_size - 1, buf[fw_size - 1]);
please, no spaces at the start of a line
Done
Patch Set #1, Line 55: buf[0], fw_size - 1, buf[fw_size - 1]);
code indent should use tabs where possible
Done
Patch Set #1, Line 65: sspm_boot
configure_sspm, to this is more consistent with other functions in same file.
Done
File src/soc/mediatek/mt8183/include/soc/addressmap.h:
tab
Done
File src/soc/mediatek/mt8183/include/soc/sspm.h:
Patch Set #1, Line 26: #define CFG_SSPM_SRAM 0x10400000
I will move it to addresmap. […]
Done
Would it be better to return int?
Done
File src/soc/mediatek/mt8183/sspm.c:
Patch Set #1, Line 22: #define SSPM_UART 1
It is about pin selection depends on platform and just for debug. […]
Done
Patch Set #1, Line 25: memcpy((void*)CFG_SSPM_SRAM, buf, len);
"(foo*)" should be "(foo *)"
Done
Patch Set #1, Line 30: mb();
memory barrier without comment
Done
Patch Set #1, Line 31: write32
resetting SSPM
Done
To view, visit change 31516. To unsubscribe, or for help writing mail filters, visit settings.