Patch set 5:Code-Review +1
48 comments:
File src/mainboard/bostentech/gbyt4/gpio.c:
GPIO_FUNC(2, PULL_UP, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_UP, 20K),
I'd say these shouldn't be pulling anything
GPIO_FUNC(0, PULL_DISABLE, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
Uh, function 0 is reserved? No idea
Patch Set #5, Line 19: GPIO_FUNC(1, PULL_DOWN, 20K),
I'd try removing the pull
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
I'd say these don't need pull down
Patch Set #5, Line 40: GPIO_FUNC(2, PULL_DOWN, 20K),
I'd say this doesn't need a pull
Patch Set #5, Line 41: GPIO_FUNC(1, PULL_UP, 20K),
SATA LED, does it work as intended with this pull?
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
These are PCIe clock request pins. I'd drop the pull and see if the Ethernet NICs still work.
Patch Set #5, Line 46: GPIO_FUNC(0, PULL_UP, 20K),
SD-related, probably NC
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
GPIO_FUNC(2, PULL_DOWN, 20K),
HDA-related, if there's no audio on your board then this should be NC
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
MMC-related, unused?
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
SD2, unused
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
SD3, unused
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
LPC pins, use GPIO_FUNC1
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
More LPC clock stuff, they can also use GPIO_FUNC1
Patch Set #5, Line 89: GPIO_FUNC(1, PULL_UP, 20K),
SERIRQ, probably doesn't need pullups
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
SMBus, should be GPIO_FUNC1
Patch Set #5, Line 93: GPIO_FUNC(1, PULL_DOWN, 20K)
Speaker
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
Strap pins, probably unused
Patch Set #5, Line 96: GPIO_FUNC(1, PULL_UP, 20K),
Integrated UART TXD, likely NC
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
Probably NC
Patch Set #5, Line 100: GPIO_FUNC(1, PULL_DOWN, 20K),
Integrated UART RXD, probably NC as well
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
I2S, pretty sure it's NC
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
SPI controller for dedicated hardware, not for the SPI flash so NC
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
UART1, most likely not connected
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
UART2, most likely NC
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
I2C ports for touchpad/touchscreen, most likely NC
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(2, PULL_UP, 20K),
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC(0, PULL_UP, 20K),
I2C ports, unused
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
PWM pins, probably unused because they are wired as GPIOs
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
Platform clocks, most likely NC.
Out of curiosity, I checked my Q1900M: it can either use these pins or a regular crystal, and it's using the latter.
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
This looks wrong, function 1 is reserved for these two
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
I'd say these are all NC
Patch Set #5, Line 151: GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC1 (PMC_SUSCLK1)
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
Most likely NC
GPIO_FUNC(0, PULL_DISABLE, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
NC
Patch Set #5, Line 156: GPIO_FUNC(0, PULL_UP, 20K),
Probably NC
Patch Set #5, Line 157: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (SUSPWRDNACK)
Patch Set #5, Line 158: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (SUSCLK)
Patch Set #5, Line 159: GPIO_FUNC(0, PULL_DOWN, 20K),
NC, probably?
Patch Set #5, Line 160: GPIO_FUNC(2, PULL_DISABLE, 20K),
GPIO_FUNC2 (USB_ULPI_RST#)
Patch Set #5, Line 161: GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC0 (PMC_WAKE_PCIE[0])
Patch Set #5, Line 162: GPIO_FUNC(0, PULL_UP, 20K),
This is the power button that needs the pullup, right?
Patch Set #5, Line 163: GPIO_FUNC(1, PULL_UP, 20K),
NC, most likely
Patch Set #5, Line 164: GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC0 (PMC_SUS_STAT#)
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC0 (USB_OC0 and USB_OC1)
Patch Set #5, Line 167: GPIO_FUNC(1, PULL_UP, 20K),
NC?
GPIO_FUNC(0, PULL_DISABLE, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_DOWN, 20K),
GPIO_FUNC(0, PULL_UP, 20K),
GPIO_FUNC(2, PULL_UP, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
GPIO_FUNC(0, PULL_DISABLE, 20K),
XDP stuff, most likely NC?
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_DISABLE, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
GPIO_FUNC(1, PULL_UP, 20K),
GPIO_FUNC(1, PULL_DOWN, 20K),
This is most likely NC as well, it's USB ULPI and would only be used in tablets, if at all...
http://web.archive.org/web/20131212023536/http://www.ulpi.org/
To view, visit change 43087. To unsubscribe, or for help writing mail filters, visit settings.