Attention is currently required from: Michał Kopeć, Michael Niewöhner.
1 comment:
Patchset:
so, we have two drivers for the same thing now, I guess? :/ CB:57034
Not sure if Tim was still able to work on that or not... so I had talked to him some and I was working on one as well... https://review.coreboot.org/c/coreboot/+/62381
We should really coordinate here. The ChromeOS device has different requirements for power sequencing (it is all driven by the PCH), so just a single "enable" GPIO won't cut it, hence why I left most of the power sequencing to the mainboard.
Also this really copies and pastes a lot from the pcie/rtd3 driver, I think we could probably do some refactoring to make this cleaner, instead of re-implementing the Intel PCIE RTD3 sequence in so many places.
To view, visit change 62496. To unsubscribe, or for help writing mail filters, visit settings.