Attention is currently required from: Tim Wawrzynczak, Brandon Breitenstein. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/47684 )
Change subject: soc/tigerlake: Update early TCSS code to not call back and forth between mainboard and soc ......................................................................
Patch Set 5:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/47684/comment/e6106c88_b02769a3 PS5, Line 9: The original implementation of early tcss resulted in calling to mainboard then back to : soc then back to mainboard to properly configure the muxes. This patch addresses that : issue and instead just gets all the mux information from mainboard and does all config : in the soc code. This also adds a new check for early display support which removes : the requirement for the system to be a vboot compatible system before executing. Commit message lines are limited to 75 characters: https://www.coreboot.org/Git#Commit_messages
Can you please fix this?
File src/soc/intel/tigerlake/early_tcss.c:
https://review.coreboot.org/c/coreboot/+/47684/comment/8c226980_807cb488 PS5, Line 2: #include <bootmode.h>
required for `display_init_required()`
https://review.coreboot.org/c/coreboot/+/47684/comment/27389b5b_b3acde2a PS5, Line 268: NULL Not required. This is set on line 275.
https://review.coreboot.org/c/coreboot/+/47684/comment/22270905_5d15d36f PS5, Line 268: struct const
as mainboard_tcss_fill_mux_info returns `const struct tcss_mux *`
File src/soc/intel/tigerlake/include/soc/early_tcss.h:
https://review.coreboot.org/c/coreboot/+/47684/comment/c523dd93_760db8d1 PS5, Line 129: //void update_tcss_mux(int port, struct tcss_mux mux_data); Drop commented out code.
https://review.coreboot.org/c/coreboot/+/47684/comment/a397e6f0_b8027792 PS5, Line 134: Weak mainboard method to setup any mux configuration needed for early TCSS operations. : * This function will need to obtain any mux data needed to forward to IOM/PMC and call : * the update_tcss_mux method which will call any PMC commands needed to connect the : * ports. Since the mux data may be stored differently by different mainboards this : * must be overridden by the mainboard with its specific mux data stored in a struct tcss_mux : * struct as defined above. Comment needs update.
https://review.coreboot.org/c/coreboot/+/47684/comment/19865522_ca60061d PS5, Line 142: mainboard_tcssfill_mux_info This doesn't match the name in early_tcss.c: mainboard_tcss_fill_mux_info