Attention is currently required from: Julius Werner, Sridhar Siricilla, Krishna P Bhat D.
13 comments:
File src/soc/intel/alderlake/romstage/romstage.c:
Separate CL to enable this for ADL please
/* If SOC is not Alderlake A2, skip update */
if (cpu_get_cpuid() != CPUID_ALDERLAKE_A2) {
printk(BIOS_INFO, "CSE Sub-partition update not required\n");
return true;
}
return false;
I would rather keep the print in common code, and then this function just becomes:
`return cpu_get_cpuid() != CPUID_ALDERLAKE_A2;`
File src/soc/intel/common/block/cse/Makefile.inc:
These blobs are part of FW_MAIN_A/FW_MAIN_B/COREBOOT, they are verified by vboot.
Ah yes I see now.
File src/soc/intel/common/block/cse/cse_lite.c:
Patch Set #11, Line 958: /* Get sub-partition blob's version */
These blobs are part of FW_MAIN_A/FW_MAIN_B/COREBOOT, they are verified by vboot.
Ack
File src/soc/intel/common/block/cse/cse_lite.c:
Patch Set #14, Line 743: uint16_t
`enum bpdt_entry_type`
Patch Set #14, Line 756: uint16_t
`enum bpdt_entry_type `
Patch Set #14, Line 799: uint16_t
`enum bpdt_entry_type`
Patch Set #14, Line 833: ptr + SUBPART_HEADER_SZ
It is technically illegal C to do pointer arithmetic on a `void *`, but GCC does allow it (and probably clang too, I'm not sure). Would prefer if you use `uint8_t *` or `uintptr_t` and then cast to pointer later.
Patch Set #14, Line 855: uint16_t
`enum bpdt_entry_type`
nit: extra blank line
/*
* If system is in recovery mode, don't trigger recovery again */
nit: single-line comment
nit: extra space
Patch Set #14, Line 1020: return;
nit: blank line after `}`
To view, visit change 59685. To unsubscribe, or for help writing mail filters, visit settings.