Attention is currently required from: Henry Sun, Raymond Chung, SH Kim, Edward Doan.
Karthik Ramasubramanian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/56762 )
Change subject: mb/google/dedede: Create bugzzy variant
......................................................................
Patch Set 1:
(1 comment)
File src/mainboard/google/dedede/variants/bugzzy/overridetree.cb:
https://review.coreboot.org/c/coreboot/+/56762/comment/d35dc05b_b03d17b9
PS1, Line 44: .scl_lcnt = 176,
: .scl_hcnt = 95,
: .sda_hold = 36,
This CL is used to create new variants. It will be configured after measurement in hardware.
I understand that. But there is a good chance that everything works well, this is forgotten and linger around. Hence I would recommend to remove it and add the right configuration later.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/56762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I851b9a75c387586d2fb84b762788e962f33472b5
Gerrit-Change-Number: 56762
Gerrit-PatchSet: 1
Gerrit-Owner: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: Edward Doan
edoan@google.com
Gerrit-Reviewer: Henry Sun
henrysun@google.com
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Reviewer: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kervin Kang
kervinkang@ami.corp-partner.google.com
Gerrit-Attention: Henry Sun
henrysun@google.com
Gerrit-Attention: Raymond Chung
raymondchung@ami.corp-partner.google.com
Gerrit-Attention: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Attention: Edward Doan
edoan@google.com
Gerrit-Comment-Date: Mon, 02 Aug 2021 20:17:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Raymond Chung
raymondchung@ami.corp-partner.google.com
Comment-In-Reply-To: Karthik Ramasubramanian
kramasub@google.com
Gerrit-MessageType: comment