Patrick Georgi merged this change.
mediatek/mt8183: Wait 200us for voltages to settle
When we increase voltages, it takes 200us for voltages to stablize.
BUG=b:80501386
BRANCH=none
Test=Boots correctly on Kukui
Change-Id: I5f32035693b6084dbe763411c612ae5d1f7c9e48
Signed-off-by: Tristan Shieh <tristan.shieh@mediatek.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32498
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: You-Cheng Syu <youcheng@google.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
---
M src/soc/mediatek/mt8183/mt6358.c
1 file changed, 6 insertions(+), 0 deletions(-)
diff --git a/src/soc/mediatek/mt8183/mt6358.c b/src/soc/mediatek/mt8183/mt6358.c
index 8162e3a..7054243 100644
--- a/src/soc/mediatek/mt8183/mt6358.c
+++ b/src/soc/mediatek/mt8183/mt6358.c
@@ -16,6 +16,7 @@
#include <console/console.h>
#include <soc/pmic_wrap.h>
#include <soc/mt6358.h>
+#include <timer.h>
static struct pmic_setting init_setting[] = {
/* [15:0]: TMA_KEY */
@@ -775,13 +776,18 @@
void mt6358_init(void)
{
+ struct stopwatch voltage_settled;
+
if (pwrap_init())
die("ERROR - Failed to initialize pmic wrap!");
pmic_set_power_hold(true);
pmic_wdt_set();
mt6358_init_setting();
+ stopwatch_init_usecs_expire(&voltage_settled, 200);
wk_sleep_voltage_by_ddr();
wk_power_down_seq();
mt6358_lp_setting();
+ while (!stopwatch_expired(&voltage_settled))
+ /* wait for voltages to settle */;
}
To view, visit change 32498. To unsubscribe, or for help writing mail filters, visit settings.