8 comments:
Patch Set #2, Line 9: Integers
integers
Ack
Patch Set #2, Line 13: sort are
Just one space.
Ack
needed
Ack
File src/commonlib/include/commonlib/sort.h:
Patch Set #2, Line 20: typedef enum{
Add a space before {?
Yes, how has it slipped in using checkpatch?
Will add.
Patch Set #2, Line 18: static void swap(int *v1, int *v2)
Should this maybe be a macro (using typeof()) in some header to be more widely useful?
I had a macro with typeof() here in the first run and was not sure. Will switch back to the macro.
Patch Set #2, Line 26: static int is_bigger(int v1, int v2)
This... […]
Agree, will move comparison into the code below.
Patch Set #2, Line 30: /* Implement a simple Bubble sort algorithm. Reduce the needed number of
Please use the allowed comment style. (No idea if clang-format would help. […]
Yes, will do.
Patch Set #2, Line 51: idx = i + 1;
I don't get the point of the idx variable. […]
Will improve.
To view, visit change 31544. To unsubscribe, or for help writing mail filters, visit settings.