View Change

2 comments:

• Commit Message:

  • Patch Set #5, Line 31: - Battery. I have it somewhere.

    yes but no. […]

    ACPI code needs to be added to communicate with the EC. Check the vendor's DSDT

• File src/mainboard/acer/es1-572/devicetree.cb:

  • Patch Set #5, Line 266: device pci 1f.5 off end # PCH SPI

    breaks rom console, too

    Off-topic, but presently, lpc_set_lock_enable in the common code locks BIOS write-enable=1. Is there any reason why this is the case, or should we fix it (preferably with a check against a lockdown related config, CONFIG_DO_NOT_TOUCH_DESCRIPTOR_REGION or CB:32704)?

To view, visit change 38978. To unsubscribe, or for help writing mail filters, visit settings.