Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31284 )
Change subject: soc/intel/cannonlake: Add required FSP UPD changes for CML ......................................................................
Patch Set 7:
@Nico, i'm requesting you to remove your personal battle between coreboot and FSP and consider your -2, this patch is nowhere eligible for -2, when i'm giving you complete inside and proposing to change the design ASAP.
Subrata, -2 simply means the change should not be merged *as is*. When the author already agreed to change it, how is it not eligible? When I give a -2, I reconsider it on every following revision of the change. Even if it was just an update to the commit message to better reflect the changes.
For now we are in middle of product and creating roadblock like this is against good development,
When is anybody not in the middle of a product? With your argument the only right time to write propper code is during vacation? I don't see how this is a roadblock. You seem to have plenty of time to argue about 10 lines of code but zero time to change them???
do you want to should not push patch into coreboot.org? i think thats your only intention too me. This is going out of control for now.
Nope, rather the opposite. I appreciate your contributions to coreboot.org. I wouldn't spent hours of review every day if I wouldn't care about it.
That I gave the -2 was rather symbolic. You were talking about a potential future clean-up while it seemed to me that Maulik already agreed to update this change. I just want to make sure you're not whipping him not to update.