Attention is currently required from: Rizwan Qureshi, Subrata Banik, Angel Pons.
6 comments:
File src/soc/intel/common/block/cpu/Kconfig:
Patch Set #9, Line 73: CAR_HAS_YMM
suggestion:
`CAR_HAS_L3_PROTECTED_WAYS`
snoop filter
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
Patch Set #9, Line 542: #if CONFIG(CAR_HAS_YMM)
This code also uses rdmsr/wrmsr and so has to use `ecx`, therefore its value must be saved first. IOW, the current structure allows you to select CAR_HAS_YMM but not CAR_HAS_SF_MASKS, and in that case, `edi` would not contain the expected backed up number of ways when you try to restore from it on line 554. Therefore, you need to save it again here too, i.e.:
```
mov %ecx, %edi
```
Patch Set #9, Line 543: /* Set MSR 0x1892 IA32_CR_SF_QOS_MASK_2 = (2^(no, of data ways) - 1) */
can you also add a clarification that this value is also the non-eviction mask?
mov %ebx, %eax
xorl %edx, %edx
IIUC, these registers should still contain these values (I don't think wrmsr should have changed these registers, just read them)
File src/soc/intel/common/block/cpu/car/exit_car.S:
Patch Set #9, Line 102: mov $0x00000, %eax
`xorl %eax, %eax`
To view, visit change 48344. To unsubscribe, or for help writing mail filters, visit settings.