Name of user not set #1002476 has uploaded this change for review.
arch/acpi.h: Avoid explicitly assign values to enum names
Compiler by default assign values starting from the initial integral constant.
Change-Id: I1a5aa9762051780b67013f67f101112fc7a0bf6e
Signed-off-by: Himanshu Sahdev <himanshusah@hcl.com>
---
M src/arch/x86/include/arch/acpi.h
1 file changed, 19 insertions(+), 19 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/30/36430/1
diff --git a/src/arch/x86/include/arch/acpi.h b/src/arch/x86/include/arch/acpi.h
index 479067f..a9bd9f6 100644
--- a/src/arch/x86/include/arch/acpi.h
+++ b/src/arch/x86/include/arch/acpi.h
@@ -302,10 +302,10 @@
enum dev_scope_type {
SCOPE_PCI_ENDPOINT = 1,
- SCOPE_PCI_SUB = 2,
- SCOPE_IOAPIC = 3,
- SCOPE_MSI_HPET = 4,
- SCOPE_ACPI_NAMESPACE_DEVICE = 5
+ SCOPE_PCI_SUB,
+ SCOPE_IOAPIC,
+ SCOPE_MSI_HPET,
+ SCOPE_ACPI_NAMESPACE_DEVICE
};
typedef struct dev_scope {
@@ -321,11 +321,11 @@
} __packed dev_scope_t;
enum dmar_type {
- DMAR_DRHD = 0,
- DMAR_RMRR = 1,
- DMAR_ATSR = 2,
- DMAR_RHSA = 3,
- DMAR_ANDD = 4
+ DMAR_DRHD,
+ DMAR_RMRR,
+ DMAR_ATSR,
+ DMAR_RHSA,
+ DMAR_ANDD
};
enum {
@@ -599,15 +599,15 @@
/* FADT Preferred Power Management Profile */
enum acpi_preferred_pm_profiles {
- PM_UNSPECIFIED = 0,
- PM_DESKTOP = 1,
- PM_MOBILE = 2,
- PM_WORKSTATION = 3,
- PM_ENTERPRISE_SERVER = 4,
- PM_SOHO_SERVER = 5,
- PM_APPLIANCE_PC = 6,
- PM_PERFORMANCE_SERVER = 7,
- PM_TABLET = 8, /* ACPI 5.0 & greater */
+ PM_UNSPECIFIED,
+ PM_DESKTOP,
+ PM_MOBILE,
+ PM_WORKSTATION3,
+ PM_ENTERPRISE_SERVER4,
+ PM_SOHO_SERVER,
+ PM_APPLIANCE_PC,
+ PM_PERFORMANCE_SERVER,
+ PM_TABLET, /* ACPI 5.0 & greater */
};
/* FACS (Firmware ACPI Control Structure) */
@@ -780,7 +780,7 @@
};
enum acpi_ipmi_interface_type {
- IPMI_INTERFACE_RESERVED = 0,
+ IPMI_INTERFACE_RESERVED,
IPMI_INTERFACE_KCS,
IPMI_INTERFACE_SMIC,
IPMI_INTERFACE_BT,
To view, visit change 36430. To unsubscribe, or for help writing mail filters, visit settings.