2 comments:
File src/soc/intel/skylake/irq.c:
Patch Set #1, Line 192: sizeof(SI_PCH_DEVICE_INTERRUPT_CONFIG));
It's used directly from the fsp-s memory. […]
Some weird assymetry there?
src/soc/intel/skylake/chip_fsp20.c: params->GraphicsConfigPtr = (u32) vbt_data;
I don't see params->DevIntConfigPtr initialised anywhere. And if it was, how amny entries can it hold?
Patch Set #1, Line 212: memcpy(params->PxRcConfig, irq_config, PCH_MAX_IRQ_CONFIG);
$ grep -r PxRcConfig 3rdparty/fsp/KabylakeFspBinPkg/ […]
Yes, it's sort of fine, except made assumption ARRAY_SIZE(PxRcConfig)<=PCH_MAX_IRQ_CONFIG.
To view, visit change 35735. To unsubscribe, or for help writing mail filters, visit settings.