Patch Set 1:

Patch Set 1:

Martin, what should we do about formatting disagreements between checkpatch and clang-format (like here)?

We'll need to fix checkpatch.

I disagree. Both objections of make sense, and clang-format should follow them, if possible.

View Change


To view, visit change 31652. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib34af7c4db359e132b968fe8409580af05fba9e3
Gerrit-Change-Number: 31652
Gerrit-PatchSet: 1
Gerrit-Owner: Patrick Georgi <>
Gerrit-Reviewer: Martin Roth <>
Gerrit-Reviewer: Patrick Georgi <>
Gerrit-Reviewer: build bot (Jenkins) <>
Gerrit-CC: Paul Menzel <>
Gerrit-Comment-Date: Mon, 04 Mar 2019 17:40:10 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment