Felix Held submitted this change.

View Change

Approvals: Derek Huang: Looks good to me, approved Eric Lai: Looks good to me, approved build bot (Jenkins): Verified Ivan Chen: Looks good to me, but someone else must approve
mb/google/brox/var/greenbayupoc: Add fw_config field for storage

Add STORAGE_UNKNOWN, STORAGE_UFS, STORAGE_NVME for storage fw_config
field to prevent depthcharge build break.

BUG=b:333325006
TEST=emerge-brox coreboot depthcharge with no errors

Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Signed-off-by: Eren Peng <peng.eren@inventec.corp-partner.google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/81833
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Ivan Chen <yulunchen@google.com>
Reviewed-by: Eric Lai <ericllai@google.com>
Reviewed-by: Derek Huang <derekhuang@google.com>
---
M src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb
1 file changed, 8 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb b/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb
index e707a9b..ee65135 100644
--- a/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb
+++ b/src/mainboard/google/brox/variants/greenbayupoc/overridetree.cb
@@ -1,3 +1,11 @@
+fw_config
+ field STORAGE 0 1
+ option STORAGE_UNKNOWN 0
+ option STORAGE_UFS 1
+ option STORAGE_NVME 2
+ end
+end
+
chip soc/intel/alderlake

device domain 0 on

To view, visit change 81833. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I0e220787d6ac73ec8fa2469ed958981d0801920e
Gerrit-Change-Number: 81833
Gerrit-PatchSet: 4
Gerrit-Owner: Eren Peng <peng.eren@inventec.corp-partner.google.com>
Gerrit-Reviewer: Derek Huang <derekhuang@google.com>
Gerrit-Reviewer: Eric Lai <ericllai@google.com>
Gerrit-Reviewer: Felix Held <felix-coreboot@felixheld.de>
Gerrit-Reviewer: Ivan Chen <yulunchen@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Garen Wu <wu.garen@inventec.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Rasheed Hsueh <hsueh.rasheed@inventec.corp-partner.google.com>
Gerrit-CC: Steven Yeh <yeh.stevenct@inventec.corp-partner.google.com>
Gerrit-MessageType: merged