Nico Huber merged this change.

View Change

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Matt DeVillier: Looks good to me, but someone else must approve
  Arthur Heymans: Looks good to me, approved
  Thomas Heijligen: Looks good to me, but someone else must approve

mb/google: Add GPU panel settings for SKL/KBL boards

The values are generated from the respective VBTs.

Change-Id: Ic74e9dac898c17ce64a94b06682997a39daeff69
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/30247
Reviewed-by: Arthur Heymans <arthur@aheymans.xyz>
Reviewed-by: Matt DeVillier <matt.devillier@gmail.com>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Paul Menzel <paulepanter@users.sourceforge.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
---
M src/mainboard/google/eve/devicetree.cb
M src/mainboard/google/fizz/variants/baseboard/devicetree.cb
M src/mainboard/google/glados/variants/asuka/devicetree.cb
M src/mainboard/google/glados/variants/caroline/devicetree.cb
M src/mainboard/google/glados/variants/cave/devicetree.cb
M src/mainboard/google/glados/variants/chell/devicetree.cb
M src/mainboard/google/glados/variants/glados/devicetree.cb
M src/mainboard/google/glados/variants/lars/devicetree.cb
M src/mainboard/google/glados/variants/sentry/devicetree.cb
9 files changed, 72 insertions(+), 0 deletions(-)

diff --git a/src/mainboard/google/eve/devicetree.cb b/src/mainboard/google/eve/devicetree.cb
index bffcf84..50f9114 100644
--- a/src/mainboard/google/eve/devicetree.cb
+++ b/src/mainboard/google/eve/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "100"
+	register "gpu_pp_down_delay_ms"		  = "500"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "1"
diff --git a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
index f1c846e..c1afe3d 100644
--- a/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
+++ b/src/mainboard/google/fizz/variants/baseboard/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "200"
+
 	# Deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/asuka/devicetree.cb b/src/mainboard/google/glados/variants/asuka/devicetree.cb
index 13dfa29..cddb10d 100644
--- a/src/mainboard/google/glados/variants/asuka/devicetree.cb
+++ b/src/mainboard/google/glados/variants/asuka/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/caroline/devicetree.cb b/src/mainboard/google/glados/variants/caroline/devicetree.cb
index 1a67cce..aabf179 100644
--- a/src/mainboard/google/glados/variants/caroline/devicetree.cb
+++ b/src/mainboard/google/glados/variants/caroline/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/cave/devicetree.cb b/src/mainboard/google/glados/variants/cave/devicetree.cb
index 9a2fc12..993cab0 100644
--- a/src/mainboard/google/glados/variants/cave/devicetree.cb
+++ b/src/mainboard/google/glados/variants/cave/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/chell/devicetree.cb b/src/mainboard/google/glados/variants/chell/devicetree.cb
index de8641c..a379757 100644
--- a/src/mainboard/google/glados/variants/chell/devicetree.cb
+++ b/src/mainboard/google/glados/variants/chell/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/glados/devicetree.cb b/src/mainboard/google/glados/variants/glados/devicetree.cb
index 0d27a44..1d9e6cd 100644
--- a/src/mainboard/google/glados/variants/glados/devicetree.cb
+++ b/src/mainboard/google/glados/variants/glados/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"
diff --git a/src/mainboard/google/glados/variants/lars/devicetree.cb b/src/mainboard/google/glados/variants/lars/devicetree.cb
index 204ade2..b8871d1 100644
--- a/src/mainboard/google/glados/variants/lars/devicetree.cb
+++ b/src/mainboard/google/glados/variants/lars/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s5_enable_ac" = "1"
 	register "deep_s5_enable_dc" = "1"
diff --git a/src/mainboard/google/glados/variants/sentry/devicetree.cb b/src/mainboard/google/glados/variants/sentry/devicetree.cb
index 89120a3..7f52586 100644
--- a/src/mainboard/google/glados/variants/sentry/devicetree.cb
+++ b/src/mainboard/google/glados/variants/sentry/devicetree.cb
@@ -1,5 +1,13 @@
 chip soc/intel/skylake
 
+	register "gpu_pp_up_delay_ms"		  = "200"
+	register "gpu_pp_down_delay_ms"		  = " 50"
+	register "gpu_pp_cycle_delay_ms"	  = "500"
+	register "gpu_pp_backlight_on_delay_ms"	  = "  1"
+	register "gpu_pp_backlight_off_delay_ms"  = "200"
+
+	register "gpu_pch_backlight_pwm_hz"	  = "1000"
+
 	# Enable deep Sx states
 	register "deep_s3_enable_ac" = "0"
 	register "deep_s3_enable_dc" = "0"

To view, visit change 30247. To unsubscribe, or for help writing mail filters, visit settings.