View Change

2 comments:

• File src/soc/intel/common/block/cpu/car/cache_as_ram.S:

  • Patch Set #2, Line 417: mov %ecx, %edi

    This seems weird. ebx was backed up to ecx and 2 lines below that ecx is backed up to edi. Why not directly back up ebx to edi?

    BTW, Tim had another suggestion on your original CL (https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/cpu/car/cache_as_ram.S#413):

    what about using %edx directly?
    ```
    mov %eax, %edx
    mov $0x01, %eax
    shl %dl, %eax
    subl $0x01, %eax
    ```

  • Patch Set #2, Line 436:

    /*
    	 * Program MSR 0x1892 IA32_CR_SF_QOS_MASK_2 with
    	 * total number of LLC ways
    	 */
    	movl	$IA32_CR_SF_QOS_MASK_2, %ecx
    	xorl	%edx, %edx
    	wrmsr
    

    This can be dropped completely: https://review.coreboot.org/c/coreboot/+/47983/5/src/soc/intel/common/block/cpu/car/cache_as_ram.S#428

To view, visit change 48286. To unsubscribe, or for help writing mail filters, visit settings.