Attention is currently required from: Angel Pons.
Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46942 )
Change subject: cpu/intel/haswell: Add Broadwell CPUIDs and microcode
......................................................................
Patch Set 16: Code-Review+2
(1 comment)
File src/cpu/intel/haswell/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46942/comment/76234124_87c138c3
PS16, Line 27: ifeq ($(CONFIG_SOC_INTEL_BROADWELL),y)
: cpu_microcode_bins += 3rdparty/blobs/soc/intel/broadwell/microcode.bin
: endif
get rid of it in soc/intel/broadwell/cpu/Makefile. […]
Uh nvm. They are made mutally exclusive later on.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46942
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I36138cab72b1e3ad0ff7f6434996f5ce00de9d0d
Gerrit-Change-Number: 46942
Gerrit-PatchSet: 16
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Comment-Date: Fri, 22 Jan 2021 19:32:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment