Patch Set 4:

Submit at your own discretion. I have no resources to improve this further wrt. allocation sizes or terminology.

I have to repeat what I wrote in CB:35165, I think in general FSP_USES_CB_STACK was a step to wrong direction wrt. amount of CAR space that is reserved. I did not look for argumentation or motivation for the change.

More importantly; the way car.ld is laid out requires DCACHE_BSP_STACK_SIZE parameter to stay constant across bootblock, verstage and romstage. Updates to FSP-M will not be allowed to have increased requirement for the stack size on systems with read-only bootblock.

View Change

To view, visit change 35233. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4cffcc73a89cb97ab7759dd373196ce9753a6307
Gerrit-Change-Number: 35233
Gerrit-PatchSet: 4
Gerrit-Owner: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Aaron Durbin <adurbin@chromium.org>
Gerrit-Reviewer: Furquan Shaikh <furquan@google.com>
Gerrit-Reviewer: Kyösti Mälkki <kyosti.malkki@gmail.com>
Gerrit-Reviewer: Nathaniel L Desimone <nathaniel.l.desimone@intel.com>
Gerrit-Reviewer: Patrick Rudolph <siro@das-labor.org>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Subrata Banik <subrata.banik@intel.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-Comment-Date: Fri, 06 Sep 2019 04:19:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment