Richard Spiegel posted comments on this change.
Patch set 1:
(3 comments)
There are instances where the pound "#" is separated from the word "define",
it should be all together "#define".
Why? This is a common convention throughout the codebase to show that this
I was not aware of this convention. I can undo it.
There are instances where bits are being declared as (1 << x), should be
replaced by macro BIT(x).
Again, the (1 << x) is very common throughout the coreboot codebase. What'
Earlier (about 2 month ago) I was requested to do that with southbridge.h. Otherwise I would not have changed it.
Patch Set #1, Line 15: 62239898
62239898 - Kahlee: coreboot - stoneyridge - include headers for filetypes u
As I mentioned in bugganizer, all that was requested was already done, and I had only seen these as possible clean up before marking the issue as fixed. If I should revert my changes, then I should probably abandon this review and close the issue (mark as fixed).
To view, visit change 22635. To unsubscribe, visit settings.