2 comments:
Patch Set #1, Line 60: (ENV_SEPARATE_VERSTAGE && CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK)))) {
What this line is really trying to say is "if we're not in the first stage that runs", which is a concept we need in multiple places. That used to always be the bootblock, but if that's now not true anymore I think we should separate it out in its own macro. How about adding an ENV_FIRST_STAGE or something like that to <rules.h> to encapsulate this?
Also, it should really be
#define ENV_FIRST_STAGE (CONFIG(VBOOT_STARTS_BEFORE_BOOTBLOCK ? ENV_SEPARATE_VERSTAGE : ENV_BOOTBLOCK)
right? You don't want this to match ENV_BOOTBLOCK on Zork because otherwise you're regenerating the cache from flash again after DRAM init. You should have passed it in from the PSP already.
Patch Set #1, Line 63: at least one FMAP access (usually from finding CBFS). */
This comment needs updating now.
To view, visit change 43488. To unsubscribe, or for help writing mail filters, visit settings.