Kane Chen has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38811 )
Change subject: mb/google/drallion: Set baseline config for U42 and U62 CPU
......................................................................
Patch Set 2:
(2 comments)
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@7
PS2, Line 7: on: Set baseline config for U42 and U62 CPU
you should say set cpu_pl2_4_cfg to baseline for Dralion.
cpu_pl2_4_cfg is by board design not CPU
https://review.coreboot.org/c/coreboot/+/38811/2//COMMIT_MSG@9
PS2, Line 9: VR settings will be selected by CPU SKU.
Proper VR settings will be selected by CPU SKU and cpu_pl2_4_cfg
--
To view, visit
https://review.coreboot.org/c/coreboot/+/38811
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ie471dee0c70e1831a822860c0a44455772a2b8be
Gerrit-Change-Number: 38811
Gerrit-PatchSet: 2
Gerrit-Owner: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Duncan Laurie
dlaurie@chromium.org
Gerrit-Reviewer: EricR Lai
ericr_lai@compal.corp-partner.google.com
Gerrit-Reviewer: John Su
john_su@compal.corp-partner.google.com
Gerrit-Reviewer: Kane Chen
kane.chen@intel.com
Gerrit-Reviewer: Marx Wang
marx.wang@intel.com
Gerrit-Reviewer: Mathew King
mathewk@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Wed, 12 Feb 2020 09:18:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment