Angel Pons submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Michael Niewöhner: Looks good to me, approved
mb/aopen/dxplplusu: Drop dead code

This code is not even being build-tested. Drop it before it grows moss.

Change-Id: I3f9b31a2bfb85ceb9ff833c076e062291c944923
Signed-off-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43242
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Michael Niewöhner
---
M src/mainboard/aopen/dxplplusu/acpi/power.asl
M src/mainboard/aopen/dxplplusu/acpi/scsi.asl
M src/mainboard/aopen/dxplplusu/acpi/superio.asl
3 files changed, 0 insertions(+), 26 deletions(-)

diff --git a/src/mainboard/aopen/dxplplusu/acpi/power.asl b/src/mainboard/aopen/dxplplusu/acpi/power.asl
index 293d5a4..903d844 100644
--- a/src/mainboard/aopen/dxplplusu/acpi/power.asl
+++ b/src/mainboard/aopen/dxplplusu/acpi/power.asl
@@ -32,13 +32,7 @@
/* PME# */
Method (_L0B, 0, NotSerialized)
{
-#if 1
Notify (\_SB.LID0, 0x02)
-#else
- Notify (\_SB.PCI0.HLIB.P64B.ETH0, 0x02)
- Notify (\_SB.PCI0.HLIB.P64B, 0x02)
- Notify (\_SB.PCI0.HLIB.P64A, 0x02)
-#endif
}

Method (_L0C, 0, NotSerialized)
diff --git a/src/mainboard/aopen/dxplplusu/acpi/scsi.asl b/src/mainboard/aopen/dxplplusu/acpi/scsi.asl
index 6f51825..c34dd4e 100644
--- a/src/mainboard/aopen/dxplplusu/acpi/scsi.asl
+++ b/src/mainboard/aopen/dxplplusu/acpi/scsi.asl
@@ -27,19 +27,3 @@
Offset (0xFF), IDW, 8
}
}
-
-#if 0
-/* Set subsystem id for both SCSI devices.
- * It may require some delay on wake-up before this can be done.
- */
- Method ( )
- {
- Or (\_SB.PCI0.HLIB.P64A.SCS0.IDW, 0x01, \_SB.PCI0.HLIB.P64A.SCS0.IDW)
- Store (0x1106A0A0, \_SB.PCI0.HLIB.P64A.SCS0.SID)
- And (\_SB.PCI0.HLIB.P64A.SCS0.IDW, 0xFE, \_SB.PCI0.HLIB.P64A.SCS0.IDW)
-
- Or (\_SB.PCI0.HLIB.P64A.SCS1.IDW, 0x01, \_SB.PCI0.HLIB.P64A.SCS1.IDW)
- Store (0x1106A0A0, \_SB.PCI0.HLIB.P64A.SCS1.SID)
- And (\_SB.PCI0.HLIB.P64A.SCS1.IDW, 0xFE, \_SB.PCI0.HLIB.P64A.SCS1.IDW)
- }
-#endif
diff --git a/src/mainboard/aopen/dxplplusu/acpi/superio.asl b/src/mainboard/aopen/dxplplusu/acpi/superio.asl
index 72be8a6..9889032 100644
--- a/src/mainboard/aopen/dxplplusu/acpi/superio.asl
+++ b/src/mainboard/aopen/dxplplusu/acpi/superio.asl
@@ -104,11 +104,7 @@
Store (0x01, GC33)
Store (0x01, GC34) /* GPI password jumper */
Store (0x01, GC35) /* GPI scsi enable jumper */
-#if 1
Store (0x01, GC42) /* GPI */
-#else
- Store (0x84, GC42) /* nIO_PME */
-#endif
Store (0x86, GC60) /* led 1 */
Store (0x81, GC61) /* led 2 ?? */


To view, visit change 43242. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I3f9b31a2bfb85ceb9ff833c076e062291c944923
Gerrit-Change-Number: 43242
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Angel Pons <th3fanbus@gmail.com>
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-MessageType: merged