Attention is currently required from: Ravi Kumar Bokka, Hung-Te Lin, Paul Menzel, Rex-BC Chen, Julius Werner, Arthur Heymans, Yu-Ping Wu, Jianjun Wang.
View Change
1 comment:
Patchset:
Patch Set #20:
Starting a new comment thread, to not further interleave the discussions.
struct lb_mtk_pcie {
uint32_t tag;
uint32_t size;
lb_uint64_t pcie_ctrl_base;
uint32_t config_offset;
uint32_t cfgnum_offset; // maybe this can change each gen too?
};
That way, the information to change the BDF config space points to and the offset to config space are known, is that sufficient for MTK?
That's sufficient for our current PCIe IP, but since we will not change the config_offset and cfgnum_offset on this PCIe IP, I'm not sure if we really need to pass these two offsets through the structure.
We can also start with `pcie_ctrl_base` and extend the struct later if
ever needed. The ABI would stay backwards compatible. Only consumers
should check for a minimum size, not a specific one (e.g. `size >= 16`
instead of `size == 16`).
To view, visit change 63251. To unsubscribe, or for help writing mail filters, visit settings.
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I6cdce21efc66aa441ec077e6fc1d5d1c6a9aafb0
Gerrit-Change-Number: 63251
Gerrit-PatchSet: 20
Gerrit-Owner: Jianjun Wang <jianjun.wang@mediatek.com>
Gerrit-Reviewer: Hung-Te Lin <hungte@chromium.org>
Gerrit-Reviewer: Julius Werner <jwerner@chromium.org>
Gerrit-Reviewer: Ravi Kumar Bokka <rbokka@codeaurora.org>
Gerrit-Reviewer: Rex-BC Chen <rex-bc.chen@mediatek.com>
Gerrit-Reviewer: Shelley Chen <shchen@google.com>
Gerrit-Reviewer: Yu-Ping Wu <yupingso@google.com>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Angel Pons <th3fanbus@gmail.com>
Gerrit-CC: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-CC: Nico Huber <nico.h@gmx.de>
Gerrit-CC: Paul Menzel <paulepanter@mailbox.org>
Gerrit-CC: Prasad Malisetty <pmaliset@qualcomm.corp-partner.google.com>
Gerrit-CC: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Attention: Ravi Kumar Bokka <rbokka@codeaurora.org>
Gerrit-Attention: Hung-Te Lin <hungte@chromium.org>
Gerrit-Attention: Paul Menzel <paulepanter@mailbox.org>
Gerrit-Attention: Rex-BC Chen <rex-bc.chen@mediatek.com>
Gerrit-Attention: Julius Werner <jwerner@chromium.org>
Gerrit-Attention: Arthur Heymans <arthur@aheymans.xyz>
Gerrit-Attention: Yu-Ping Wu <yupingso@google.com>
Gerrit-Attention: Jianjun Wang <jianjun.wang@mediatek.com>
Gerrit-Comment-Date: Sat, 30 Apr 2022 13:57:03 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment