Felix Singer submitted this change.
mb/intel/tglrvp/dt: Remove superfluous USB2_PORT_EMPTY settings
Configuring USB2_PORT_EMPTY is equal to just not setting it. So remove
it to clean up a bit.
Change-Id: I6854f4a0d3e7b51b242549556a5838d4183d3473
Signed-off-by: Felix Singer <felixsinger@posteo.net>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/83246
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Eric Lai <ericllai@google.com>
---
M src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
M src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
2 files changed, 0 insertions(+), 5 deletions(-)
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
index fede521..9c5fa6d 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up3/devicetree.cb
@@ -181,7 +181,6 @@
device ref south_xhci on
register "usb2_ports" = "{
[0] = USB2_PORT_MID(OC0), // Type-C Port1
- [1] = USB2_PORT_EMPTY, // M.2 WWAN
[2] = USB2_PORT_MID(OC3), // M.2 Bluetooth
[3] = USB2_PORT_MID(OC0), // USB3/2 Type A port1
[4] = USB2_PORT_MID(OC0), // Type-C Port2
diff --git a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
index 23ccfb9..578eb98 100644
--- a/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
+++ b/src/mainboard/intel/tglrvp/variants/tglrvp_up4/devicetree.cb
@@ -189,14 +189,10 @@
device ref south_xhci on
register "usb2_ports" = "{
[0] = USB2_PORT_MID(OC3), // Type-C Port1
- [1] = USB2_PORT_EMPTY, // M.2 WWAN
[2] = USB2_PORT_MID(OC0), // M.2 Bluetooth, USB3/2 Type A Port1
[3] = USB2_PORT_MID(OC3), // USB3/2 Type A Port 1
[4] = USB2_PORT_MID(OC3), // Type-C Port2
[5] = USB2_PORT_MID(OC3), // Type-C Port3 / MECC
- [6] = USB2_PORT_EMPTY, // Not used
- [7] = USB2_PORT_EMPTY, // Not used
- [8] = USB2_PORT_EMPTY, // Not used
[9] = USB2_PORT_MID(OC3), // CNVi/BT
}"
To view, visit change 83246. To unsubscribe, or for help writing mail filters, visit settings.