[coreboot-gerrit] [M] Change in coreboot[main]: arch/arm64: Support calling a trusted monitor

[Arthur Heymans (Code Review)]

Attention is currently required from: Benjamin Doron, David Milosevic, Julius Werner.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78284?usp=email )

Change subject: arch/arm64: Support calling a trusted monitor
......................................................................

Patch Set 13:

(1 comment)

File src/arch/arm64/smc.c:

https://review.coreboot.org/c/coreboot/+/78284/comment/fcb85c89_3908cbcb :
PS11, Line 10: inline uint64_t smc_call(uint32_t function_id, uint64_t arg1, uint64_t arg2, uint64_t arg3,
> I actually found that other boards broke if this file was compiled unconditionally. Possibly because CONFIG_ARM64_CURRENT_EL has no value? We can probably drop the assert if the Makefile guarantees it anyways.

The coreboot implementation of assert checks if the argument is a buildtime constant and if the argument is false that would trigger failed builds.