Tim Wawrzynczak submitted this change.

View Change

Approvals: build bot (Jenkins): Verified Tim Wawrzynczak: Looks good to me, approved
mb/google/volteer: Add a DPTF policy for Eldrid

1. Enable dptf feature and remove fan control part from overridetree.cb
2. Update tcc offset to 5
3. Follow thermal validation and update PL2 max_power to 51

BUG=b:167931578, b:170357248

Signed-off-by: Nick Chen <nick_xr_chen@wistron.corp-partner.google.com>
Change-Id: I99e429b90ed7de08385fe51ca742865b1266eef9
Reviewed-on: https://review.coreboot.org/c/coreboot/+/45860
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Tim Wawrzynczak <twawrzynczak@chromium.org>
---
M src/mainboard/google/volteer/variants/eldrid/overridetree.cb
1 file changed, 43 insertions(+), 1 deletion(-)

diff --git a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
index 5fcd456..7fd6576 100644
--- a/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
+++ b/src/mainboard/google/volteer/variants/eldrid/overridetree.cb
@@ -1,5 +1,15 @@
chip soc/intel/tigerlake

+ register "power_limits_config[POWER_LIMITS_U_2_CORE]" = "{
+ .tdp_pl1_override = 15,
+ .tdp_pl2_override = 51,
+ }"
+ register "power_limits_config[POWER_LIMITS_U_4_CORE]" = "{
+ .tdp_pl1_override = 15,
+ .tdp_pl2_override = 51,
+ }"
+
+ register "tcc_offset" = "5" # TCC of 95
register "TcssAuxOri" = "1"
register "DdiPort1Hpd" = "0"
register "DdiPort2Hpd" = "0"
@@ -58,7 +68,39 @@
}"

device domain 0 on
- device ref dptf off end
+ device ref dptf on
+ # DPTF Policy for Eldrid board
+ chip drivers/intel/dptf
+
+ ## Disable Active Policy from baseboard
+ register "policies.active" = "{[0] = {.target=DPTF_NONE}}"
+
+ ## Passive Policy
+ register "policies.passive[0]" = "DPTF_PASSIVE(CPU,CPU,95,5000)"
+ register "policies.passive[1]" = "DPTF_PASSIVE(CPU,TEMP_SENSOR_2,60,6000)"
+
+ ## Critical Policy
+ register "policies.critical[0]" = "DPTF_CRITICAL(CPU,100,SHUTDOWN)"
+ register "policies.critical[1]" = "DPTF_CRITICAL(TEMP_SENSOR_2,80,SHUTDOWN)"
+
+ ## Power Limits Control
+ # 3-15W PL1 in 200mW increments, avg over 28-32s interval
+ # PL2 is fixed at 51W, avg over 28-32s interval
+ register "controls.power_limits" = "{
+ .pl1 = {.min_power = 3000,
+ .max_power = 15000,
+ .time_window_min = 28 * MSECS_PER_SEC,
+ .time_window_max = 32 * MSECS_PER_SEC,
+ .granularity = 200,},
+ .pl2 = {.min_power = 15000,
+ .max_power = 51000,
+ .time_window_min = 28 * MSECS_PER_SEC,
+ .time_window_max = 32 * MSECS_PER_SEC,
+ .granularity = 1000,}}"
+
+ device generic 0 on end
+ end
+ end
device ref i2c0 on
chip drivers/i2c/generic
register "hid" = ""10EC5682""

To view, visit change 45860. To unsubscribe, or for help writing mail filters, visit settings.

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I99e429b90ed7de08385fe51ca742865b1266eef9
Gerrit-Change-Number: 45860
Gerrit-PatchSet: 27
Gerrit-Owner: Nick Chen <nick_xr_chen@wistron.corp-partner.google.com>
Gerrit-Reviewer: Keith Short <keithshort@google.com>
Gerrit-Reviewer: Nick Vaccaro <nvaccaro@google.com>
Gerrit-Reviewer: Tim Wawrzynczak <twawrzynczak@chromium.org>
Gerrit-Reviewer: build bot (Jenkins) <no-reply@coreboot.org>
Gerrit-CC: Anfernee Chen <anfernee_chen@wistron.corp-partner.google.com>
Gerrit-CC: Casper Chang <casper_chang@wistron.corp-partner.google.com>
Gerrit-CC: Keith Short <keithshort@chromium.org>
Gerrit-CC: Malik Hsu <malik_hsu@wistron.corp-partner.google.com>
Gerrit-CC: Mark Hsieh <mark_hsieh@wistron.corp-partner.google.com>
Gerrit-CC: Paul Menzel <paulepanter@users.sourceforge.net>
Gerrit-CC: Scott Chao <scott_chao@wistron.corp-partner.google.com>
Gerrit-CC: Sumeet R Pawnikar <sumeet.r.pawnikar@intel.com>
Gerrit-CC: Terry Chen <terry_chen@wistron.corp-partner.google.com>
Gerrit-MessageType: merged