Attention is currently required from: Tim Wawrzynczak, Angel Pons, Nick Vaccaro, Werner Zeh, Patrick Rudolph, EricR Lai.
1 comment:
File src/soc/intel/alderlake/finalize.c:
/* Function to set D0I3 for all HECI devices */
void soc_set_d0i3_for_heci(void)
{
unsigned int cse_dev[] = {
PCH_DEVFN_CSE,
PCH_DEVFN_CSE_2,
PCH_DEVFN_CSE_3,
PCH_DEVFN_CSE_4
};
for (int i = 0; i < ARRAY_SIZE(cse_dev); i++) {
if (!is_cse_devfn_visible(cse_dev[i]))
continue;
set_cse_device_state(cse_dev[i], DEV_IDLE);
}
}
Could this function just be moved to common code?
The only reason why I would prefer to have HECI device lists coming from SoC layer instead common code because of number of HECI device.
ADL, CNL, ICL, JSL, => 4 HECI devices
SKL => 3 HECI devices
TGL => 3 HECI devices (but there is mistake it should be 4 as per EDS)
After reading your comments I had another idea, let me try something today.
To view, visit change 61518. To unsubscribe, or for help writing mail filters, visit settings.