6 comments:
File src/soc/qualcomm/sdm845/Kconfig:
Convention is to indent 2 spaces here, not a tab (don't ask me why...)
File src/soc/qualcomm/sdm845/include/soc/qcom_qup_se.h:
This should already not be in here in the first patch that adds this file, not added and then removed again.
File src/soc/qualcomm/sdm845/uart.c:
Patch Set #76, Line 76: GENI_STATUS_S_GENI_CMD_ACTIVE_MASK)
Fits on one line now? (If not, please align with opening parenthesis.)
Patch Set #76, Line 130: (unsigned char)
nit: unnecessary cast (I think?)
Patch Set #76, Line 143: (unsigned int)
nit: unnecessary cast
No space after a cast
To view, visit change 25373. To unsubscribe, or for help writing mail filters, visit settings.