devicetree looks much cleaner!! 😎
2 comments:
File src/soc/intel/alderlake/romstage/fsp_params.c:
Patch Set #24, Line 23: pcie_clk_src_usage
suggestion: `convert_clk_src_to_fsp`
!is_dev_enabled(dev) ? 0
: pcie_rp_init(m_cfg, CPU_PCIE_RP, config->cpu_pcie_rp, CONFIG_MAX_ROOT_PORTS);
suggestion: I think this reads easier inverted, i.e.,
```
m_cfg->CpuPcieRpEnableMask = is_dev_enabled(dev) ? pcie_rp_init(m_cfg, CPU_PCIE_RP, config->cpu_pcie_rp, CONFIG_MAX_ROOT_PORTS) : 0;
```
To view, visit change 48340. To unsubscribe, or for help writing mail filters, visit settings.