Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39949 )
Change subject: nb/intel/sandybridge: Simplify GMA SSDT generator
......................................................................
Patch Set 4: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/39949/4/src/northbridge/intel/sandy...
File src/northbridge/intel/sandybridge/gma.c:
https://review.coreboot.org/c/coreboot/+/39949/4/src/northbridge/intel/sandy...
PS4, Line 643: device
dev
https://review.coreboot.org/c/coreboot/+/39949/4/src/northbridge/intel/sandy...
PS4, Line 646: chip
is chip null?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39949
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If34ebe0edc46674244c9d5afc7ed165c2ad685ba
Gerrit-Change-Number: 39949
Gerrit-PatchSet: 4
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 31 Mar 2020 11:05:45 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment