[coreboot-gerrit] [M] Change in coreboot[master]: security/vboot: Add store/validate methods for VBIOS FMAP cache

[Matt DeVillier (Code Review)]

Attention is currently required from: Andrey Pronin, Raul Rangel, Martin L Roth, Julius Werner, Martin Roth, Yu-Ping Wu, Karthik Ramasubramanian.

Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/72401 )

Change subject: security/vboot: Add store/validate methods for VBIOS FMAP cache
......................................................................

Patch Set 4:

(1 comment)

File src/security/vboot/secdata_tpm.c:

https://review.coreboot.org/c/coreboot/+/72401/comment/075b3c2a_9c273c08 
PS4, Line 520: return
> Why would we choose to always return instead of continuing to write the buffer out after setting up  […]

it appears that setup_space() calls safe_write() as long as define_space() succeeds, so 1) the buffer is getting written, and 2) the RV will only be successful if safe_write() succeeds, so we're ok there