View Change

2 comments:

• File src/arch/riscv/arch_timer.c:

  • Patch Set #1, Line 31: die("time not set in HLS");

    does this HAVE to be a die? Can we somehow stumble along with bad values?

  • Patch Set #1, Line 33: die("Unsupported mtime clock frequency");

    Could you use static assert instead? […]

    Like Philip said. It's depressing to configure a value wrong and end up with a basic brick :-)

To view, visit change 33797. To unsubscribe, or for help writing mail filters, visit settings.