[coreboot-gerrit] Change in ...coreboot[master]: arch/riscv: Fix arch timer timebase

[ron minnich (Code Review)]

ron minnich has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33797 )

Change subject: arch/riscv: Fix arch timer timebase
......................................................................


Patch Set 1:

(2 comments)

https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c 
File src/arch/riscv/arch_timer.c:

https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c@31 
PS1, Line 31: 		die("time not set in HLS");
does this HAVE to be a die? Can we somehow stumble along with bad values?


https://review.coreboot.org/#/c/33797/1/src/arch/riscv/arch_timer.c@33 
PS1, Line 33: 		die("Unsupported mtime clock frequency");
> Could you use static assert instead? […]
> Like Philip said. It's depressing to configure a value wrong and end up with a basic brick :-)